Fix: check all pending brackets have been closed when matching bracket #10712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When asking matching bracket, we check all pending brackets have been closed in plain text:
And we didn't check it if there an tree-sitter for this language.
However, some language's
indents.scm
may be rudimentary. If there is multiple matching brackets within the same node, the indents will become incorrect. This PR add this check so that the indents are at least as good as when there is no language support available.An example in protobuf, write following in
test.proto
:And after the fix: